Logging + Perf optimizations #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
esemeniuc
commented
May 18, 2024
•
esemeniuc
commented
- Avoid relayer recomputing recipients on every packet batch (do every slot update instead
- Use Arcswap instead of rwlock for leader schedule (faster, no chance of starvation)
- Reduce datapoint rates, emit highest slot metric only when new slot
- Reduce channel forwarding for HealthManager
- Delete irrelevant metrics
- Less calls to fetch SystemTime
- Early return a bunch of places
esemeniuc
force-pushed
the
eric/metrics-perf
branch
from
7872d51 to
af8761d
Compare
esemeniuc
requested review from
jedleggett,
segfaultdoc and
buffalu
and removed request for
jedleggett
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.