Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert public ip is ipv4 #99

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Assert public ip is ipv4 #99

merged 2 commits into from
Jan 24, 2024

Conversation

buffalu
Copy link
Contributor

@buffalu buffalu commented Jan 24, 2024 •
edited
Loading

Problem:

  • When running a GET request against ifconfig.me, sometimes the service returns an IPv6 address.
  • This IP address is passed to the validator and the validator attempts to parse it as IPv4.

Fix:

  • This fix asserts the IP address is IPv4 with detailed instructions on how to fix it.

Longer term, need to look at IP address providers that provide an option to only get IPv4 addresses back.

@buffalu buffalu requested a review from jedleggett January 24, 2024 00:24
@buffalu buffalu merged commit 755785b into master Jan 24, 2024
3 checks passed
@buffalu buffalu deleted the lb/assert_ipv4 branch January 24, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segfaultdoc segfaultdoc segfaultdoc approved these changes

@jedleggett jedleggett Awaiting requested review from jedleggett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buffalu @segfaultdoc