Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip Router: Fix stack frame initialize_weight_table #13

Closed

Conversation

aoikurokawa
Copy link
Contributor

@aoikurokawa aoikurokawa commented Nov 24, 2024

We currently have issue with initialize_weight_table:

cargo-build-sbf --dump

Error: Function _ZN23jito_tip_router_program23initialize_weight_table31process_initialize_weight_table17h6eb3696e2ef38ac9E Stack offset of 6688 exceeded max offset of 4096 by 2592 bytes, please minimize large stack variables. Estimated function frame size: 6880 bytes. Exceeding the maximum stack offset may cause undefined behavior during execution.

By shifting the logic out of the main function, stack size usage in the main function is reduced, which helps to prevent stack overflow errors, i think.

At least after fixing, i dont see the error and test still passes.

@aoikurokawa aoikurokawa changed the title Tip Router: Fix stack frame Tip Router: Fix stack frame initialize_weight_table Nov 24, 2024
@ebatsell
Copy link
Collaborator

Addressed in #20

@ebatsell ebatsell closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants