Skip to content

Commit

Permalink
cli: remove now redundant dunce::simplified() from run_ui_editor()
Browse files Browse the repository at this point in the history
The tests still use dunce::simplified() so we won't reintroduce the problem.
  • Loading branch information
yuja committed Dec 22, 2024
1 parent 78b5766 commit 2aaf6cc
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions cli/src/cli_util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2852,9 +2852,6 @@ impl LogContentFormat {
}

pub fn run_ui_editor(settings: &UserSettings, edit_path: &Path) -> Result<(), CommandError> {
// Work around UNC paths not being well supported on Windows (no-op for
// non-Windows): https://github.com/jj-vcs/jj/issues/3986
let edit_path = dunce::simplified(edit_path);
let editor: CommandNameAndArgs = settings.get("ui.editor")?;
let mut cmd = editor.to_command();
cmd.arg(edit_path);
Expand Down

0 comments on commit 2aaf6cc

Please sign in to comment.