completion: teach log about files #4898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvonz
reviewed
Nov 17, 2024
senekor
force-pushed
the
remo/mknomzkwyqpz
branch
from
ccbcdf3 to
ad8d992
Compare
senekor
force-pushed
the
remo/mzrpqkvpnokm
branch
from
5810f2f to
26e5947
Compare
thoughtpolice
approved these changes
Nov 18, 2024
yuja
reviewed
Nov 19, 2024
senekor
force-pushed
the
remo/mknomzkwyqpz
branch
2 times, most recently
from
81eb10d to
06822e3
Compare
senekor
force-pushed
the
remo/mzrpqkvpnokm
branch
from
26e5947 to
76f9f1e
Compare
senekor
force-pushed
the
remo/mknomzkwyqpz
branch
from
06822e3 to
eb0d240
Compare
senekor
force-pushed
the
remo/mzrpqkvpnokm
branch
from
76f9f1e to
bc3a485
Compare
senekor
force-pushed
the
remo/mknomzkwyqpz
branch
from
eb0d240 to
bc8e78b
Compare
senekor
force-pushed
the
remo/mzrpqkvpnokm
branch
from
bc3a485 to
5692a4b
Compare
senekor
force-pushed
the
remo/mzrpqkvpnokm
branch
from
5692a4b to
652ea19
Compare
|
If we're only reading files from one revision anyway, I think it's easiest to reuse |
yuja
reviewed
Dec 1, 2024
senekor
force-pushed
the
remo/mzrpqkvpnokm
branch
from
652ea19 to
e0246cc
Compare
senekor
force-pushed
the
remo/mzrpqkvpnokm
branch
from
e0246cc to
05f2669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stacked on #4895 (suggest file paths incrementally)
Checklist
If applicable:
CHANGELOG.md