Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: deprecate --config-toml #5119

Merged
merged 2 commits into from
Dec 17, 2024
Merged

cli: deprecate --config-toml #5119

merged 2 commits into from
Dec 17, 2024

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Dec 17, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

yuja added 2 commits December 17, 2024 11:06
@yuja
cli: replace --config-toml=TOML with --config=NAME=VALUE
cfb27c7
@yuja
cli: deprecate --config-toml
e1a8e4a 
Typical usage should now be covered by --config=NAME=VALUE.

Closes jj-vcs#3867
martinvonz
martinvonz approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yuja yuja merged commit f87c6ed into jj-vcs:main Dec 17, 2024
18 checks passed
@yuja yuja deleted the push-oowxkwlnzunk branch December 17, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonz martinvonz martinvonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuja @martinvonz