Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

absorb: move core functionality from cli to lib #5127

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

torquestomp
Copy link
Contributor

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

Copy link
Contributor

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since its a NFC change

@torquestomp
Copy link
Contributor Author

LGTM, since its a NFC change

It looks like your approval isn't enough to let the PR through, possible permissions changes with the domain move?

Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing if I can review a PR

@torquestomp torquestomp enabled auto-merge (rebase) December 17, 2024 19:37
@torquestomp torquestomp merged commit 396833f into jj-vcs:main Dec 17, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants