-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed auto-detected typos #5149
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
WTF? So I'm granting google specifically the right to do whatever the f**k it wants with my contributions irrespective of the project license now and forever? Uhh... No? I'd much rather start my own fork than this. You're claiming that this is a community project, even though google is involved. That rings hollow if I have to sign this shit. |
See #4849 for additional discussion. (Please upvote/react if this blocks you, as it would probably be useful data to take to the Google lawyers at some point?) I am not a lawyer, but I'm not sure that the specific text you're quoting is as unusual as you're remarking.
To me, it seems that the CLA is not practically that useful, and it certainly would be better for the project if we didn't have it, but it seems like it will be an uphill battle to remove it for now. |
@arxanas Yeah, I just finished diving into the CLA. You (people at google) should really have a word with your legal department. IMHO this is all very unnecessary (See discord). FYI, I ended up signing the CLA. Granting google an apache license plus a DCO seems reasonable. |
I discovered
jj
a few days ago, and it seems pretty neat!While I familiarize myself with the codebase (there will be an actual PR at some point, I promise), here's a few typos
typos
was screaming at me for.