-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --reversed
flag to evolog
#5170
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
979ad4a
to
6c8a8ce
Compare
This can be at most two commits until Yuya shows up for the |
To make sure I understand: You'd like the second commit to be what is currently 32c4449 and then the first commit to be everything else? Some of the clippy lints apply to code from 32c444 so I might have to split it. |
No, you can add the flag, most of the implementation, test and CHANGELOG entry in a single commit while keeping a second commit (32c4449) with the fixed clippy lints, where Yuya will probably know the solution to whenever he shows up. |
c464993
to
5fbc376
Compare
Ok I think I've got it all compressed. Let me know if it's not quite what you're looking for 👍 |
edcb463
to
6ef0146
Compare
@yuja I've pushed up some new changes based off your refactoring work. I hadn't realized the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit, I'll let Yuya do the final review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
9f7fb00
to
a903115
Compare
f9f4495
to
e27df6c
Compare
@yuja I think everything is resolved now. UPDATE: I made one small follow-up correction since this update needed to be moved to the "unreleased" section of the changelog. |
Adds some additional helper functions for converting between jj_lib's GraphEdge and the graphlog's Edge type.
e27df6c
to
edee305
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, thanks!
Resolves #5088
Checklist
If applicable:
CHANGELOG.md