escape bookmark and remote names in trunk() config
#5475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvonz
force-pushed
the
push-ksxxwyqmryom
branch
2 times, most recently
from
50443ab to
6d7b96b
Compare
yuja
reviewed
Jan 26, 2025
martinvonz
force-pushed
the
push-ksxxwyqmryom
branch
6 times, most recently
from
8265518 to
bc8d8d9
Compare
martinvonz
force-pushed
the
push-ksxxwyqmryom
branch
3 times, most recently
from
3704195 to
a976eec
Compare
martinvonz
force-pushed
the
push-ksxxwyqmryom
branch
from
a976eec to
57b2994
Compare
yuja
approved these changes
Jan 31, 2025
When we have e.g. a bookmark name or a remote name and we want to produce a revset from it, we may need to quote and escape it. This patch implements a function for that. Perhaps we'll want to more generally be able to format a whole `RevsetExpression` later.
martinvonz
force-pushed
the
push-ksxxwyqmryom
branch
from
57b2994 to
ac8ec0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md