Add test for custom menulink tag helper
#6
Labels
Comments
jjwilliams42
pushed a commit
that referenced
this issue
Mar 5, 2016
- Add semantic.validation.min.js for consistency - Add tests for Semantic UI overrides per #9 and #6 - Add <% namespace %> to _Layout.cshtml (missing) - Remove title from MenuLinkTagHelper rendering per #5 - Remove commented out code and extra call to $('.class').checkbox() in Login.cshtml - Remove commented out code in various cshtml files - Merged in functionality to use Semantic OR Bootstrap libraries using yo menu selection or command line argument
jjwilliams42
pushed a commit
to jjwilliams42/generator-aspnet
that referenced
this issue
Mar 5, 2016
- Add semantic.validation.min.js for consistency - Add tests for Semantic UI overrides per jjwilliams42/generator-aspnet-semanticui#9 and jjwilliams42/generator-aspnet-semanticui#6 - Add <% namespace %> to _Layout.cshtml (missing) - Remove title from MenuLinkTagHelper rendering per jjwilliams42/generator-aspnet-semanticui#5 - Remove commented out code and extra call to $('.class').checkbox() in Login.cshtml - Remove commented out code in various cshtml files - Merged in functionality to use Semantic OR Bootstrap libraries using yo menu selection or command line argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
menulink (MenuLinkTagHelper) is a custom addition not ported from aspnet/Templates. I think it should be covered by tests ("created template contains a menulink tag"), to avoid situation that copying content from aspnet/Templates after update removes that custom tag from views markup. Theaspnet-generator` covers some (not all) custom and crucial addition to default templates.Thanks!
The text was updated successfully, but these errors were encountered: