Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: tweets not rendering when they are paragraph element #2300

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

nakedfool
Copy link
Contributor

@nakedfool nakedfool commented Sep 9, 2024

Closes #2297

Sometimes tweets come as p paragraph element rather than as a anchor element, not sure if this is due to user pasting incorrectly or our markdown editor making a mistake.

However, we should check if the paragraph contains full link for the tweet and render it in that case.

Copy link
Member

@siobh9 siobh9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nakedfool nakedfool merged commit 0d68464 into staging Sep 9, 2024
2 checks passed
@nakedfool nakedfool deleted the bugfix/tweet-not-rendering-as-paragraph branch September 9, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: tweet not rendering automatically in frontend
2 participants