Skip to content

Commit

Permalink
[ci] Disable dependabot updates for compat tests (ray-project#29783)
Browse files Browse the repository at this point in the history
Dependabot seems to try to update fixed requirements in our compatibility tests (e.g. ray-project#29782). By moving these into a separate directory and specifying a separate update policy, we should be able to avoid these unwanted updates.

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Co-authored-by: Amog Kamsetty <[email protected]>
  • Loading branch information
krfricke and amogkam authored Oct 28, 2022
1 parent aecba4d commit dedc024
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .buildkite/pipeline.build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@
commands:
- cleanup() { if [ "${BUILDKITE_PULL_REQUEST}" = "false" ]; then ./ci/build/upload_build_info.sh; fi }; trap cleanup EXIT
- ./ci/env/install-minimal.sh 3.6
- pip install -r python/requirements/ml/requirements_py36_compat.txt
- pip install -r python/requirements/compat/requirements_py36_compat.txt
- pip install -U typing-extensions
- HOROVOD_WITH_GLOO=1 HOROVOD_WITHOUT_MPI=1 HOROVOD_WITHOUT_MXNET=1 HOROVOD_WITH_TENSORFLOW=1 HOROVOD_WITH_PYTORCH=1 pip install horovod
- ./ci/env/env_info.sh
Expand All @@ -615,7 +615,7 @@
- cleanup() { if [ "${BUILDKITE_PULL_REQUEST}" = "false" ]; then ./ci/build/upload_build_info.sh; fi }; trap cleanup EXIT
- ./ci/env/install-minimal.sh 3.7
- DATA_PROCESSING_TESTING=1 TUNE_TESTING=1 TRAIN_TESTING=1 ./ci/env/install-dependencies.sh
- pip install -r python/requirements/ml/requirements_legacy_compat.txt
- pip install -r python/requirements/compat/requirements_legacy_compat.txt
- pip install -U typing-extensions
- HOROVOD_WITH_GLOO=1 HOROVOD_WITHOUT_MPI=1 HOROVOD_WITHOUT_MXNET=1 HOROVOD_WITH_TENSORFLOW=1 HOROVOD_WITH_PYTORCH=1 pip install horovod
- ./ci/env/env_info.sh
Expand Down
14 changes: 12 additions & 2 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ updates:
- package-ecosystem: "pip"
# If we want to add more requirements here (Core, Serve, etc.), then we should
# make additional subdirectories for each one.
directory: "/python/requirements/air"
directory: "/python/requirements/ml"
schedule:
# Automatic upgrade checks Saturday at 12 AM.
# Dependabot updates can still be manually triggered via Github at any time.
Expand All @@ -15,12 +15,22 @@ updates:
# Use Pacific Standard Time.
timezone: "America/Los_Angeles"
commit-message:
prefix: "[tune]"
prefix: "[air]"
include: "scope"
# Only 5 upgrade PRs open at a time.
open-pull-requests-limit: 5
reviewers:
- "ray-project/ray-tune"
# compat requirements should not be updated
- package-ecosystem: "pip"
directory: "/python/requirements/compat"
commit-message:
prefix: "[air/do-not-merge]"
include: "scope"
ignore: *
open-pull-requests-limit: 0
reviewers:
- "ray-project/ray-tune"
# Data Requirements.
- package-ecosystem: "pip"
directory: "/python/requirements/data_processing"
Expand Down
4 changes: 2 additions & 2 deletions ci/build/build-docker-images.py
Original file line number Diff line number Diff line change
Expand Up @@ -368,8 +368,8 @@ def prep_ray_ml():
]
# We don't need these in the ml docker image
ignore_requirements = [
"python/requirements/ml/requirements_legacy_compat.txt",
"python/requirements/ml/requirements_py36_compat.txt",
"python/requirements/compat/requirements_legacy_compat.txt",
"python/requirements/compat/requirements_py36_compat.txt",
]

files_on_disk = glob.glob(f"{root_dir}/python/**/requirements*.txt", recursive=True)
Expand Down

0 comments on commit dedc024

Please sign in to comment.