fix: do not store refresh token, if empty.

Signed-off-by: Jan-Otto Kröpke <[email protected]>
jkroepke · Nov 12, 2024 · 231a407 · 231a407
1 parent ca56ed3
commit 231a407
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/internal/oauth2/refresh.go b/internal/oauth2/refresh.go
@@ -72,18 +72,18 @@ func (p *Provider) RefreshClientAuth(logger *slog.Logger, client connection.Clie
 	logger.Info("successful authenticate via refresh token")
 
 	refreshToken, err = p.Provider.GetRefreshToken(tokens)
-	if err != nil {
-		if errors.Is(err, types.ErrNoRefreshToken) {
-			logMessage := logger.WarnContext
-			if client.SessionState == "AuthenticatedEmptyUser" || client.SessionState == "Authenticated" {
-				logMessage = logger.DebugContext
-			}
 
-			logMessage(ctx, fmt.Errorf("oauth2.refresh is enabled, but %w", err).Error())
-		} else {
-			logger.WarnContext(ctx, fmt.Errorf("oauth2.refresh is enabled, but %w", err).Error())
+	switch {
+	case errors.Is(err, types.ErrNoRefreshToken):
+		logMessage := logger.WarnContext
+		if client.SessionState == "AuthenticatedEmptyUser" || client.SessionState == "Authenticated" {
+			logMessage = logger.DebugContext
 		}
-	} else {
+
+		logMessage(ctx, fmt.Errorf("oauth2.refresh is enabled, but %w", err).Error())
+	case err != nil:
+		logger.WarnContext(ctx, fmt.Errorf("oauth2.refresh is enabled, but %w", err).Error())
+	default:
 		logger.DebugContext(ctx, "store new refresh token into token store")
 
 		if err = p.storage.Set(id, refreshToken); err != nil {