Nette 2.4 compatibility #42

jkuchar · 2016-09-20T08:50:03Z

thanks @akyn84 @lubo

@lubo

…akyn84, @lubo)

@lubo

…e\Database (thanks @akyn84, @lubo)

jkuchar · 2016-09-20T08:51:18Z

MultipleFileUpload/Model/IQueue.php

@@ -72,7 +72,7 @@ function addFileManually($name, $chunk, $chunks);
 	 * @param type $chunk
 	 * @param FileUpload $file
 	 */
-	function updateFile($name, $chunk, FileUpload $file = null);
+	function updateFile($name, $chunk, FileUpload $file);


@akyn84 why?

I put this question conversely: is there special reason to have optional parameter?

Exactly. :)

jkuchar · 2016-09-20T08:53:08Z

MultipleFileUpload/Model/MySQL/Queue.php

@@ -0,0 +1,162 @@
+<?php


@akyn84 what was wrong with original nette\database + MySQL implementation? https://github.com/jkuchar/MultipleFileUpload/tree/master/MultipleFileUpload/Model/NetteDatabase

Nette\Database implementation was not in last release (1.1.0) donwloaded by composer thus I did not notice it is in master branch by Zdeněk Jurka. Probably it solve most of issues with nette 2.4? (Nette\Environment, etc.)

I check just right now and for sure it is not compatible with PHP 7 so I will continue in update.

Nette\Database implementation was not in last release use Nette\Environments, I am reverting to my orignal solution -> when it will be approved, i will refactor all Models but firs i need to confirm MySQL namespace (later it can be removed)

namespace should be names as the target for the bridge. You you name namespace mysql, I would expect to that this driver will use mysql_* functions

jkuchar · 2016-09-20T08:54:10Z

MultipleFileUpload/Model/MySQL/Queue.php

+            $stmt->execute();
+		}
+		$this->query("COMMIT WORK");
+	}


@akyn84 mixing of spaces + tabs

jkuchar · 2016-09-20T08:54:32Z

MultipleFileUpload/Model/MySQL/Queue.php

+	 */
+	function updateFile($name, $chunk, FileUpload $file)
+	{
+		$this->query("START TRANSACTION");


@akyn84 why not use Nette database ->startTransaction() ?

jkuchar · 2016-09-20T08:56:10Z

MultipleFileUpload/MultipleFileUpload.php

+        self::init();
+		$application = $container->getByType('Nette\Application\Application');
+		$application->onStartup[] = [__CLASS__, "handleUploads"];
+		$application->onShutdown[] = [__CLASS__, "cleanCache"];


@akyn84 This whole registration should be moved into Container Extension? Are you going to handle that?

yes, tomorrow as proper nette DI Extension

jkuchar · 2016-09-20T08:58:35Z

MultipleFileUpload/UI/Plupload/Controller.php

 	}


-	/**
+	/**}}


jkuchar · 2016-09-20T08:59:52Z

MultipleFileUpload/MultipleFileUpload.php

-			self::setQueuesModel(new Model\SQLite3\Queues());
+		if (!self::$queuesModel) { // if nothing is set, setup sqlite model, which should work on all systems with MySQL
+            $queuesModel = new Model\MySQL\Queues(self::$container, self::$container->getService("database.default"));
+			self::setQueuesModel($queuesModel);


@akyn84 remove this magic default?

model inject as string namespace in constructor as in Registrator->getInterfaces() ?

…ormatting)

jkuchar · 2016-10-04T20:14:07Z

MultipleFileUpload/Extension.php

+        $initialize->addBody('MultipleFileUpload\MultipleFileUpload::init($this->getByType(?), $this->getParameters());', ['Nette\Http\IRequest']);
+        $initialize->addBody('MultipleFileUpload\MultipleFileUpload::register($this->getService(?));', ['mfuStorage']);
+        $initialize->addBody('$this->getService(?)->onStartup[] = [?, ?];', ['application', 'MultipleFileUpload\MultipleFileUpload', 'handleUploads']);
+        $initialize->addBody('$this->getService(?)->onShutdown[] = [?, ?];', ['application', 'MultipleFileUpload\MultipleFileUpload', 'cleanCache']);


completely missing configuration of storage driver + UIs

jkuchar · 2016-10-04T20:15:40Z

MultipleFileUpload/Model/NetteDatabase/Queues.php

+		};
+		$cacheStorage = new Nette\Caching\Storages\FileStorage(self::$uploadsTempDir);
+		$structure = new Nette\Database\Structure($connection, $cacheStorage);
+		$this->database = new Nette\Database\Context($connection, $structure);


Whole Database\Context should be injected. IT is responsibility of DI container to create connection.

jkuchar · 2016-10-04T20:16:53Z

MultipleFileUpload/MultipleFileUpload.php


 	/**
 	 * Initialize MFU
 	 */
-	public static function init()
+	public static function init(Nette\Http\IRequest $request, Array $parameters)


static methods from this class init(), register(), ... needs to be split into another class that will be created and registered in constructor. MFU will then take this object as a dependency.

when this functionality is removed to separate class and injected in constructor, dependencies are missing in MultipleFileUpload::handleUploads called on startup of application. If handleUploads is dynamic and called on Nette\Application\Application->startUp[], class itself is initialized before attached to component (too soon). can be logic of MultipleFileUpload::handleUploads solved outside of class with completly independent service?

JosefRypacek · 2016-10-19T15:55:07Z

Hi,
thanks for your updates, but it's still not usable with nette 2.4.
e.g. getInterfaces() instead of getInterfaces(self::$request) in getHead() or Environment in templates and probably much more. Is there any chance that it will be working again?
Thanks

jkuchar · 2016-10-19T16:23:25Z

im accepting PR on this. we can make a conf call with @landrisek who is working on this

toretak · 2018-04-12T21:41:01Z

MultipleFileUpload/Model/Dibi/Queues.php

 		}
-		return self::$dibiConnection;
+		$this->conection = $conection;


the class variable is called connection

so it should be

$this->connection = $conection;

toretak · 2018-04-12T21:44:45Z

MultipleFileUpload/Model/Dibi/Queues.php

-	 * @return \DibiConnection
-	 */
-	function getConnection()
+	public function __construct(string $tempDir, DibiConnection $conection)


only note: the latest version of dibi has Dibi\Connection instead of DibiConnection.. it would be nice to be compatible with latest dibi

JosefRypacek · 2018-09-27T11:58:05Z

Can you please give me a note how to setup current MFU from nette-2-4-compatibility branch? Latest commit I was able to setup with nette 2.4 is dev-nette-2-4-compatibility#e53eac88cabddb27ed1d8b3ba942ca353620d49e and I have to use following:

bootstrap.php

error_reporting(~E_USER_DEPRECATED);
\MultipleFileUpload\MultipleFileUpload::register();
\MultipleFileUpload\MultipleFileUpload::setQueuesModel(new \MultipleFileUpload\Model\NetteDatabase\Queues($container->getByType('\Nette\Database\Context')));

and replace "->add(" with "->addHtml(" in MultipleFileUpload.php

jkuchar · 2018-09-27T14:54:20Z

To be honest, I do not know as I do not use this code on Nette 2.4, when you figure it out (XDebug is your friend), clould you please post it here?

jkuchar added 4 commits September 20, 2016 10:47

composer: bumped compatibility with nette ~2.4 (thanks @akyn84, @lubo)

e53eac8

got rid of Environment (introduced dependency on Container) (thanks @…

9c46056

…akyn84, @lubo)

latter: {? replaced with {php (thanks @akyn84, @lubo)

570f0d6

model: introduced second implementation of driver for MySQL over Nett…

6b06f4c

…e\Database (thanks @akyn84, @lubo)

jkuchar commented Sep 20, 2016

View reviewed changes

jkuchar changed the title ~~Nette 2 4 compatibility~~ Nette 2.4 compatibility Sep 20, 2016

jkuchar and others added 15 commits September 20, 2016 12:17

.gitignore: vendor, .idea

fb01df6

MySQL driver: removed

27d2bc9

NetteDatabaseModel: removed magic configuration from container (+ ref…

db98b25

…ormatting)

NetteDatabase/Queues.php: added depencency on Container

d4da69a

MultipleFileUpload: added dependency on container

30a814a

DI extension: introduced simple extension

bd73dcb

MultipleFileUpload: explicit register() function parameters

91614d6

Queues: ???

7c2d610

UI\Registrator: requires HttpRequest insted of container

683510a

UI\AbstractInterface: requires HttpRequest instead of Container

4cbaf8b

Queues: fixed edge case

d3a6884

notes

6f9352f

MultipleFileUpload: formatting

c763cf5

formatting

e53bc11

refactoring: removed wrongly used ternary operator

27ef5c5

jkuchar commented Oct 4, 2016

View reviewed changes

DI model

d30cb32

landrisek and others added 5 commits October 22, 2016 14:13

[Extension]

9aa59f3

[Nette\Environment][DI connection]

adf2552

[Nette\Environment][DI connection][sqlite][swf]

3f573d9

[NetteDatabase php 5.6 cmopatibility]

3820012

todos and comments

1494fbf

DibiDriver: removed static queues variable

9ac871b

toretak reviewed Apr 12, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nette 2.4 compatibility #42

Nette 2.4 compatibility #42

jkuchar commented Sep 20, 2016

jkuchar Sep 20, 2016

landrisek Sep 23, 2016

jkuchar Sep 24, 2016

jkuchar Sep 20, 2016

landrisek Sep 20, 2016

landrisek Sep 20, 2016

landrisek Sep 23, 2016

jkuchar Sep 24, 2016

jkuchar Sep 20, 2016

jkuchar Sep 20, 2016

landrisek Sep 23, 2016

jkuchar Sep 20, 2016

landrisek Sep 24, 2016

jkuchar Sep 20, 2016

landrisek Sep 24, 2016

jkuchar Sep 20, 2016

landrisek Sep 24, 2016

jkuchar Oct 4, 2016

jkuchar Oct 4, 2016

jkuchar Oct 4, 2016

landrisek Oct 22, 2016

JosefRypacek commented Oct 19, 2016

jkuchar commented Oct 19, 2016

toretak Apr 12, 2018

toretak Apr 12, 2018 •

edited

Loading

JosefRypacek commented Sep 27, 2018 •

edited

Loading

jkuchar commented Sep 27, 2018

               	}
-              	/**
+              	/**}}

Nette 2.4 compatibility #42

Are you sure you want to change the base?

Nette 2.4 compatibility #42

Conversation

jkuchar commented Sep 20, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JosefRypacek commented Oct 19, 2016

jkuchar commented Oct 19, 2016

Choose a reason for hiding this comment

toretak Apr 12, 2018 • edited Loading

Choose a reason for hiding this comment

JosefRypacek commented Sep 27, 2018 • edited Loading

jkuchar commented Sep 27, 2018

toretak Apr 12, 2018 •

edited

Loading

JosefRypacek commented Sep 27, 2018 •

edited

Loading