Add 'vscode-kafka.api.saveclusters' and 'vscode-kafka.api.deleteclusters' commands

[fbricon]

Signed-off-by: Fred Bricon [email protected]

[fbricon]

we should prolly move that out from the wizard namespace

[angelozerr]

For me addCluster should be renamed to saveCluster and it's a command handler. I suggest that you create in commands/clusters.ts a new class

export class SaveClusterCommandHandler {

    constructor(private clusterSettings: ClusterSettings, private explorer: KafkaExplorer) {
    }

    async execute(clusters: Cluster[]): Promise<void> {
        try {
            // Save collected clusters in settings.
            let createdClusterNames = '';
            for (const cluster of clusters) {
                this.clusterSettings.upsert(cluster);
                if (createdClusterNames !== '') {
                    createdClusterNames += '\', \'';
                }
                createdClusterNames += cluster.name;
            }
            vscode.window.showInformationMessage(`${clusters.length > 1 ? `${clusters.length} clusters` : 'Cluster'} '${createdClusterNames}' created successfully`);
    
            // Refresh the explorer
            this.explorer.refresh();
    
            // Selecting the created cluster is done with TreeView#reveal
            // 1. Show the treeview of the explorer (otherwise reveal will not work)
            this.explorer.show();
            // 2. the reveal() call must occur within a timeout(),
            // while waiting for a fix in https://github.com/microsoft/vscode/issues/114149
            setTimeout(() => {
                if (clusters) {
                    this.explorer.selectClusterByName(clusters[0].name);
                }
            }, 1000);
        }
        catch (error) {
            showErrorMessage(`Error while creating cluster`, error);
        }
    }
}

and you consume it in extension.ts and wizard both.

[angelozerr]

We should really add a Developer section to explain how to extend vscode-kafka with #129 and you new command.

[angelozerr]

I think wizard création should wait for SaveClusterCommandHandler command and after we could consume it to savez clusters

[fbricon]

yeah I had something like that before the new wizard, but after rebasing, I just wanted to push something that compiles

[angelozerr]

You have managed select cluster in SaveCommandHandler, it's nice, but you should remove all method which use selectCluster parameter;

[fbricon]

done

[angelozerr]

You missed some code.

• in commons.ts => addClusterCommandHandler.execute(); (line 48)
• Add 'vscode-kafka.api.saveclusters' and 'vscode-kafka.api.deleteclusters' commands #189 (comment)

[angelozerr]

async execute(): Promise<void> {

[fbricon]

fixed

[angelozerr]

It works great, thanks @fbricon !