Add text-only prompt element for console-ui #1138
Open
+217
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quintesse
force-pushed
the
text_only_prompt
branch
from
da89289 to
129477c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1136
First stab at implementing this new text-only element. It won't win any beauty contests, but it works. WDYT @mattirn ?
NB: I considered creating a
TextPromptand usingConsoleUIItemIFfor the lines of theTextelement, but between the fact thatTextPromptwould be mostly empty (because we're not actually asking for input) , the fact that items only deal withStrings, notAttributedStringsand the fact that eachXxxxPromptonly displays a single line of result it just wasn't a good fit.