#76 umap_transform crash with 0 rows

jlmelville · Apr 14, 2022 · 43e76ab · 43e76ab
1 parent be493ed
commit 43e76ab
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/R/transform.R b/R/transform.R
@@ -287,6 +287,9 @@ umap_transform <- function(X = NULL, model = NULL,
       X <- as.matrix(X[, indexes])
     }
     n_vertices <- nrow(X)
+    if (n_vertices < 1) {
+      stop("Not enough rows in X")
+    }
     if (!is.null(row.names(X))) {
       Xnames <- row.names(X)
     }

diff --git a/tests/testthat/test_errors.R b/tests/testthat/test_errors.R
@@ -74,3 +74,7 @@ nnsp10_nbr0 <- nnsp10
 nnsp10_nbr0[, 5] <- 0
 nnsp10_nbr0 <- Matrix::drop0(nnsp10_nbr0)
 expect_error(umap(X = NULL, n_neighbors = 4, nn_method = nnsp10_nbr0), "at least one neighbor")
+
+# 76: umap_transform does not validate input sufficiently
+model <- umap(iris[1:10, ], n_neighbors = 4, n_epochs = 0, ret_model = TRUE)
+expect_error(trans <- umap_transform(iris[0, ], model = model), "Not enough rows")