Skip to content

Commit

Permalink
Do not hardcode port in config.ru
Browse files Browse the repository at this point in the history
  • Loading branch information
@ntalbott
ntalbott committed Apr 6, 2012
1 parent 0ccfa60 commit fc1f849
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions lib/serve/bootstrap/config.ru
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#\ -p 4000

require 'rubygems'
require 'bundler'
begin
Expand Down
2 changes: 0 additions & 2 deletions website/config.ru
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#\ -p 4000

require 'rubygems'
require 'bundler'
begin
Expand Down

3 comments on commit fc1f849

@jlong
Copy link
Owner

@jlong jlong commented on fc1f849 Apr 6, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change would serve still start it on 4000 if no port was specified?

@ntalbott
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, so I'm confused as I look at this more closely. What's the desired behavior?

  • Rails app: 3000
  • Rack app that's been generated via serve (?): 4000
  • Other rack app (?): 3000
  • Other?

I'm not liking having the port hard-coded in config.ru, since it basically overrides even passing the port in via the command line, but I want to make sure I'm clear on the desired behavior before I "fix" this.

@jlong
Copy link
Owner

@jlong jlong commented on fc1f849 Apr 6, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks right

Please sign in to comment.