Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always record new datapoints, even if they haven't changed value #2

Closed
wants to merge 1 commit into from

Conversation

jmason
Copy link
Owner

@jmason jmason commented Dec 9, 2022

I noticed that I was missing some large chunks of data overnight on some graphs -- on investigating, it appears that if the data value hasn't changed, the sensor's value isn't recorded. (Since I use Graphite downstream from my Home Assistant to display graphs, it highlights missing data like this, whereas HA's own graphs are more lenient.) I also think it's useful to record the datapoints if we were successfully able to measure them, to differentiate from cases where the datapoint was unmeasureable due to a bug or other issue (which unfortunately tends to happen to me a fair bit due to wifi issues).

@jmason jmason force-pushed the jmason/always-record-updates branch from 3715399 to 425fac9 Compare December 10, 2022 23:46
@jmason jmason changed the base branch from master to jmason/add-soh December 12, 2022 10:59
@jmason jmason changed the title WIP always record updates always record updates, and sync scraping to the API update schedule if possible Dec 12, 2022
@jmason jmason closed this Dec 15, 2022
@jmason jmason force-pushed the jmason/always-record-updates branch from b494d09 to 2cbafdd Compare December 15, 2022 11:41
@jmason jmason reopened this Dec 15, 2022
@jmason jmason changed the title always record updates, and sync scraping to the API update schedule if possible always record updates, and sync scraping to the API update schedule if possible to improve "freshness" Dec 15, 2022
@jmason jmason changed the base branch from jmason/add-soh to master December 16, 2022 11:42
@jmason jmason changed the title always record updates, and sync scraping to the API update schedule if possible to improve "freshness" always record new datapoints, even if they haven't changed value Dec 16, 2022
@jmason jmason force-pushed the jmason/always-record-updates branch 2 times, most recently from f268ee9 to 4074303 Compare December 16, 2022 11:50
@jmason jmason force-pushed the jmason/always-record-updates branch from 4074303 to ade1a8f Compare December 16, 2022 11:51
@jmason jmason marked this pull request as draft December 16, 2022 11:53
@jmason jmason closed this Dec 21, 2022
@jmason
Copy link
Owner Author

jmason commented Dec 21, 2022

now opened upstream as hultenvp#239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant