Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two commits to those in PR #261 to use File::Path::Tiny to remove the temp files. They are also rebased on current main.
Passes the tests added by @f20
An alternate approach would be to use File::Find to list all the files under the temp dir, sorted by depth, and then delete them using unlink.
There are two new warnings related to tainting. I'm not sure how important they are.
As a side note, I wonder if the temp dirs should have a prefix such as
ewxlsx
so they are easier to identify on the temp dir. I can add that if it is considered useful, or open a separate PR.