Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAP7-2103 #4

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

jmfinelli
Copy link
Owner

No description provided.

@jmfinelli jmfinelli force-pushed the EAP7-2103_squeezed_version_of_task_force_branch branch from 0157e42 to 7222d24 Compare July 5, 2024 08:55
@jmfinelli jmfinelli force-pushed the EAP7-2103_squeezed_version_of_task_force_branch branch from 7222d24 to 0b51794 Compare July 5, 2024 08:59
@jmfinelli jmfinelli force-pushed the EAP7-2103_squeezed_version_of_task_force_branch branch from eebfbba to 7f0a3f8 Compare July 5, 2024 14:33
@jmfinelli jmfinelli force-pushed the EAP7-2103_squeezed_version_of_task_force_branch branch from 5886fd3 to 538b8dc Compare July 8, 2024 09:29
@jmfinelli jmfinelli force-pushed the EAP7-2103_squeezed_version_of_task_force_branch branch from 12a4fd8 to 1c6e5a2 Compare July 8, 2024 12:46
@jmfinelli jmfinelli force-pushed the EAP7-2103_squeezed_version_of_task_force_branch branch from 1c6e5a2 to 56485e3 Compare July 8, 2024 13:05
@tomjenkinson
Copy link

I think it would be helpful (if it doesn't exist) to have a JBTM to capture this specific feature. I think it is something like, "Provide a method for Recovery Modules to block the Recovery Manager from suspending"

@jmfinelli jmfinelli force-pushed the EAP7-2103_squeezed_version_of_task_force_branch branch 2 times, most recently from 96cb78c to a7a331b Compare July 16, 2024 16:15
@tomjenkinson
Copy link

Apart from my last comment, it looks very nice to me thank you

@tomjenkinson
Copy link

(and to squash to a commit with prefix JBTM-3894)

@jmfinelli jmfinelli force-pushed the EAP7-2103_squeezed_version_of_task_force_branch branch 2 times, most recently from 4c531e5 to 9efcb24 Compare July 16, 2024 17:03
@jmfinelli jmfinelli force-pushed the EAP7-2103_squeezed_version_of_task_force_branch branch from 9efcb24 to 74b9de4 Compare July 16, 2024 17:04
@jmfinelli jmfinelli force-pushed the EAP7-2103_squeezed_version_of_task_force_branch branch from 8159f5d to 99b3f49 Compare July 18, 2024 17:09
@jmfinelli jmfinelli force-pushed the EAP7-2103_squeezed_version_of_task_force_branch branch from 99b3f49 to b777f79 Compare July 19, 2024 08:40
@jmfinelli jmfinelli force-pushed the EAP7-2103_squeezed_version_of_task_force_branch branch from b777f79 to e52de19 Compare July 19, 2024 10:05
@jmfinelli
Copy link
Owner Author

jmfinelli commented Jul 19, 2024

All above conversation are resolved! Thank you very much for your reviews @tomjenkinson

BTW, I squashed all commits in a new branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants