Further type improvements for or helper

[wagenet]

• Improves the or helper types to correctly handle removing falsy types.
• Corrects TruthConvert types to better handle non-literal types (e.g. number vs 1).

[SergeAstapov]

Published as v4.0.3, thank you @wagenet!

[boris-petrov]

Can someone explain to me why so much time is spent updating the types for or? That's only relative to Glint, correct? But hasn't everyone configured their Glint to use additionalSpecialForms for or? Why are these improvements here needed in that case at all?

[SergeAstapov]

But hasn't everyone configured their Glint to use additionalSpecialForms for or?

TBH I only found out this exists only after researching about how generics can be handled in Glint and had no idea that exists before, by stumbling upon this discussion typed-ember/glint#547 (comment)

We could, probably, PR docs for additionalSpecialForms with and and or helpers in Glint and then point to that from ember-truth-helpers README, however I personally not sure that's what exactly we should be doing, but indeed it's an option.

[Techn1x]

But hasn't everyone configured their Glint to use additionalSpecialForms for or?

had no idea this existed, I doubt many others know of it either. good to know though, and that typed-ember discussion linked above is very helpful!

[wagenet]

I'm honestly not entirely sold on additionalSpecialForms in Glint. I feel a bit uncomfortable about lying about my actual types.