Remove empty query prefixes

jncraton · Apr 21, 2024 · 529a8c7 · 529a8c7
1 parent 39a6210
commit 529a8c7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/changelog.md b/changelog.md
@@ -2,6 +2,10 @@
 
 ## 0.20
 
+### Fixed
+
+- Allow missing query prefixes for embedding models
+
 ### Added
 
 - Support GIST-small-Embedding-v0 embedding model

diff --git a/languagemodels/config.py b/languagemodels/config.py
@@ -346,7 +346,6 @@ class ModelFilterException(Exception):
     {
         "name": "all-MiniLM-L6-v2",
         "tuning": "embedding",
-        "query_prefix": "",
         "params": 22e6,
         "quantization": "int8",
         "backend": "ct2",
@@ -356,7 +355,6 @@ class ModelFilterException(Exception):
     {
         "name": "gte-tiny",
         "tuning": "embedding",
-        "query_prefix": "",
         "params": 22e6,
         "quantization": "int8",
         "backend": "ct2",
@@ -366,7 +364,6 @@ class ModelFilterException(Exception):
     {
         "name": "gte-small",
         "tuning": "embedding",
-        "query_prefix": "",
         "params": 33e6,
         "quantization": "int8",
         "backend": "ct2",
@@ -395,7 +392,6 @@ class ModelFilterException(Exception):
     {
         "name": "e5-small-v2",
         "tuning": "embedding",
-        "query_prefix": "",
         "params": 33e6,
         "quantization": "int8",
         "backend": "ct2",

diff --git a/languagemodels/embeddings.py b/languagemodels/embeddings.py
@@ -52,7 +52,7 @@ def search(query, docs, count=16):
     :return: List of (doc_num, score) tuples sorted by score descending
     """
 
-    prefix = get_model_info("embedding")["query_prefix"]
+    prefix = get_model_info("embedding").get("query_prefix", "")
 
     query_embedding = embed([f"{prefix}{query}"])[0]