add Vector::insert_ord_by[_key] methods #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlmutolo
force-pushed
the
vector-insert-ord-by
branch
from
a7ab4df to
5bbdce5
Compare
|
This PR is a resubmission of the PR made on the original |
Users frequently want to use a custom ordering for their Vector types. One way to accomplish this is to implement the Ord trait (along with PartialOrd and usually PartialEq/Eq) using the desired custom logic for comparisons. However, this can lead to a lot of boilerplate code for what is often a small, one-off use case. This has to to the Standard Library, and libraries like imbl that offer similar APIs, creating methods such as sort_by, sort_by_key, etc. that allow a user to pass a comparator function that the library will use to sort or insert into the list. This PR implements the insert_ord_by and insert_order_by_key methods, providing a way to use a custom comparator function to insert into a sorted list without needing to define the usual Rust comparison traits.
vlmutolo
force-pushed
the
vector-insert-ord-by
branch
from
5bbdce5 to
318670d
Compare
jneem
approved these changes
Aug 15, 2021
|
Thanks for the quick merge! That was an impressive turnaround time. checks watch I think it's been two hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users frequently want to use a custom ordering for their Vector types. One way to accomplish this is to implement the Ord trait (along with PartialOrd and usually PartialEq/Eq) using the desired custom logic for comparisons.
However, this can lead to a lot of boilerplate code for what is often a small, one-off use case. This has to to the Standard Library, and libraries like imbl that offer similar APIs, creating methods such as sort_by, sort_by_key, etc. that allow a user to pass a comparator function that the library will use to sort or insert into the list.
This PR implements the insert_ord_by and insert_order_by_key methods, providing a way to use a custom comparator function to insert into a sorted list without needing to define the usual Rust comparison traits.