Remove the InProgress and Failure value param. #54
Conversation
src/app/examples/pos/pos.html
Outdated
| @@ -24,8 +24,7 @@ | |||
| <div | |||
| *ngIf=" | |||
| (service.meow$ | async | isSuccess) || | |||
| ((service.meow$ | async | isInProgress) && | |||
| (service.meow$ | async | inProgressValue)) | |||
| (service.meow$ | async | isInProgress) | |||
There was a problem hiding this comment.
I'm just briefly checking from my phone, I have not run the example. My understanding is that we don't need to show this element when it's in progress, since we don't have a cat anymore
| (service.meow$ | async | successValue)?.file || | ||
| (service.meow$ | async | inProgressValue)?.file | ||
| " | ||
| [src]="(service.meow$ | async | successValue)?.file" |
There was a problem hiding this comment.
And if you agree and we show this section only when it's success, we won't need this check for null ? anymore
There was a problem hiding this comment.
The ? is needed because the successValue pipe has some logic for providing a defaultValue that allows the transform to return undefined (because defaultValue is optional.
src/app/examples/pos/pos.html
Outdated
| @@ -23,8 +23,7 @@ | |||
| <!-- Success --> | |||
| <div | |||
| *ngIf=" | |||
| (service.meow$ | async | isSuccess) || | |||
| (service.meow$ | async | isInProgress) | |||
| (service.meow$ | async | isSuccess) | |||
There was a problem hiding this comment.
That works correct, but probably we should improve the style and simplify the code to be just <div *ngIf="service.meow$ | async | isSuccess"> (on a single line and without parentheses)
See #53 for context
Install