Rely on the pull-request btn instead of readme to detect the home page

joaodelgado · Dec 21, 2017 · dd72135 · dd72135
1 parent 65d66c2
commit dd72135
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/js/Github.js b/src/js/Github.js
@@ -55,11 +55,15 @@ export default class GitHub {
     }
 
     inRepoHome() {
-        return !!document.querySelector(this.readmeSelector());
+        return !!document.querySelector(this.pullRequestButtonSelector());
     }
 
-    readmeSelector() {
-        return '#readme article';
+    pullRequestButtonSelector() {
+        return '.new-pull-request-btn';
+    }
+
+    fileNavigatorSelector() {
+        return '.file-navigation';
     }
 
     _repoHomePath() {

diff --git a/src/js/client.js b/src/js/client.js
@@ -37,14 +37,14 @@ function init() {
 
     // Create base elements
     if (!document.getElementById(BUTTONS_ID)) {
-        const buttonsBase = document.querySelector('.new-pull-request-btn');
+        const buttonsBase = document.querySelector(github.pullRequestButtonSelector());
         const buttonsWrapper = document.createElement('div');
         buttonsWrapper.id = BUTTONS_ID;
         buttonsBase.after(buttonsWrapper);
     }
 
     if (!document.getElementById(BADGES_ID)) {
-        const badgesBase = document.querySelector('.file-navigation');
+        const badgesBase = document.querySelector(github.fileNavigatorSelector());
         const badgesWrapper = document.createElement('div');
         badgesWrapper.id = BADGES_ID;
         badgesBase.after(badgesWrapper);
@@ -71,5 +71,5 @@ const listener = () => {
     init();
 };
 
-document.arrive(github.readmeSelector(), listener);
+document.arrive(github.pullRequestButtonSelector(), listener);
 listener();