Minor code quality improvements

jobapis · Jul 24, 2015 · a40a12a · a40a12a
1 parent ea5b8c3
commit a40a12a
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 22 deletions.
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -2,7 +2,6 @@
 <phpunit backupGlobals="false"
          backupStaticAttributes="false"
          bootstrap="vendor/autoload.php"
-         colors="true"
          convertErrorsToExceptions="true"
          convertNoticesToExceptions="true"
          convertWarningsToExceptions="true"

diff --git a/src/Careerbuilder.php b/src/Careerbuilder.php
@@ -30,16 +30,16 @@ class Careerbuilder extends AbstractProvider
      *
      * @var string
      */
-    protected $enableCompanyCollapse;
+    protected $companyCollapse;
 
     /**
      * Returns the standardized job object
      *
-     * @param array $payload
+     * @param array $payload Raw job payload from the API
      *
      * @return \JobBrander\Jobs\Client\Job
      */
-    public function createJobObject($payload)
+    public function createJobObject($payload = [])
     {
         $defaults = [
             'Company',
@@ -64,7 +64,8 @@ public function createJobObject($payload)
 
         $payload = static::parseAttributeDefaults($payload, $defaults);
 
-        $job = new Job([
+        $job = new Job(
+            [
             'description' => $payload['DescriptionTeaser'],
             'employmentType' => $payload['EmploymentType'],
             'title' => $payload['JobTitle'],
@@ -75,7 +76,8 @@ public function createJobObject($payload)
             'experienceRequirements' => $payload['ExperienceRequired'],
             'minimumSalary' => $payload['Pay'],
             'sourceId' => $payload['DID'],
-        ]);
+            ]
+        );
 
         $job->setOccupationalCategoryWithCodeAndTitle(
             $payload['OnetCode'],
@@ -118,7 +120,7 @@ public function getUseFacets()
      *
      * @return string
      */
-    public function getEnableCompanyCollapse()
+    public function getCompanyCollapse()
     {
         return 'true';
     }
@@ -136,7 +138,7 @@ public function getFormat()
     /**
      * Get listings path
      *
-     * @return  string
+     * @return string
      */
     public function getListingsPath()
     {
@@ -146,7 +148,7 @@ public function getListingsPath()
     /**
      * Get parameters
      *
-     * @return  array
+     * @return array
      */
     public function getParameters()
     {
@@ -160,45 +162,47 @@ public function getParameters()
      */
     public function getQueryString()
     {
-        $query_params = [
+        $queryParams = [
             'DeveloperKey' => 'getDeveloperKey',
             'Keywords' => 'getKeyword',
             'FacetState' => 'getState',
             'FacetCity' => 'getCity',
             'PageNumber' => 'getPage',
             'PerPage' => 'getCount',
             'UseFacets' => 'getUseFacets',
-            'EnableCompanyCollapse' => 'getEnableCompanyCollapse',
+            'EnableCompanyCollapse' => 'getCompanyCollapse',
         ];
 
-        $query_string = [];
+        $queryString = [];
 
-        array_walk($query_params, function ($value, $key) use (&$query_string) {
-            $computed_value = $this->$value();
-            if (!is_null($computed_value)) {
-                $query_string[$key] = $computed_value;
+        array_walk(
+            $queryParams, function ($value, $key) use (&$queryString) {
+                $computedValue = $this->$value();
+                if (!is_null($computedValue)) {
+                    $queryString[$key] = $computedValue;
+                }
             }
-        });
+        );
 
-        return http_build_query($query_string);
+        return http_build_query($queryString);
     }
 
     /**
      * Get url
      *
-     * @return  string
+     * @return string
      */
     public function getUrl()
     {
-        $query_string = $this->getQueryString();
+        $queryString = $this->getQueryString();
 
-        return 'http://api.careerbuilder.com/v2/jobsearch/?'.$query_string;
+        return 'http://api.careerbuilder.com/v2/jobsearch/?'.$queryString;
     }
 
     /**
      * Get http verb
      *
-     * @return  string
+     * @return string
      */
     public function getVerb()
     {