feat: add liveness + readiness Probe to deployment (#163)

* feat: add liveness + readiness Probe to deployment * use .Values.certManager.containerPort instead of hard-coded values across the helm-chart
joe-elliott · Jun 27, 2024 · 65c33a0 · 65c33a0
1 parent 2215ebd
commit 65c33a0
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/helm/cert-exporter/templates/cert-manager/cert-manager.yaml b/helm/cert-exporter/templates/cert-manager/cert-manager.yaml
@@ -45,12 +45,23 @@ spec:
           {{- end}}
           ports:
             - name: http
-              containerPort: 8080
+              containerPort: {{ .Values.certManager.containerPort }}
               protocol: TCP
           resources:
             {{- toYaml .Values.certManager.resources | nindent 12 }}
           volumeMounts:
            {{- toYaml .Values.certManager.volumeMounts | nindent 12 }}
+          livenessProbe:
+            tcpSocket:
+              port: {{ .Values.certManager.containerPort }}
+            initialDelaySeconds: 10
+            periodSeconds: 10
+          readinessProbe:
+            httpGet:
+              path: /metrics
+              port: {{ .Values.certManager.containerPort }}
+              failureThreshold: 1
+              periodSeconds: 10
       {{- with .Values.certManager.nodeSelector }}
       nodeSelector:
         {{- toYaml . | nindent 8 }}

diff --git a/helm/cert-exporter/templates/cert-manager/service.yaml b/helm/cert-exporter/templates/cert-manager/service.yaml
@@ -13,6 +13,6 @@ spec:
   ports:
     - port: {{ .Values.service.port }}
       name: {{ .Values.service.portName }}
-      targetPort: 8080
+      targetPort: {{ .Values.certManager.containerPort }}
   selector:
     {{ include "cert-exporter.certManagerSelectorLabels" . | nindent 6 }}
diff --git a/helm/cert-exporter/values.yaml b/helm/cert-exporter/values.yaml
@@ -63,6 +63,8 @@ certManager:
     #   name: kubelet
     #   readOnly: true
 
+  containerPort: 8080
+
 service:
   type: ClusterIP
   port: 8080