Add timeout to attributionTokenWithError to prevent hangs #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In our production app, we were getting stacktraces like these:
Based on reading the branch.io fix, it looks like it's possible that this function is just hanging.
Fix
Adapted fix from BranchMetrics/ios-branch-deep-linking-attribution#1114 with some minor changes to pass through errors.
Testing
Built and ran app with the changes and verified that we still successfully retrieved the token on a real iOS device.
Did not verify that the timeout works, but I'll report back in a few weeks after I release the next version to see if this fixes it.