Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated iAd Attribution API and fix Xcode v16 builds #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

BohdanPylypchuk
Copy link

After updating Xcode to version 16, I started getting the error undefined symbol: _objc_class_$_adclient.
This PR fix the error by removing the deprecated iAd Attribution API
After February 7, 2023, all requests made to the Apple Search Ads iAd Attribution API will return with a value of "iad-attribution" = false, or errors. (https://developer.apple.com/documentation/iad/setting-up-apple-search-ads-attribution)

@BohdanPylypchuk BohdanPylypchuk marked this pull request as draft September 19, 2024 14:27
@BohdanPylypchuk BohdanPylypchuk marked this pull request as ready for review September 19, 2024 14:27
@ludovicthomas
Copy link

@joel-bitar Is it possible to merge this one as it's blocking all XCode 16 builds?

@BohdanPylypchuk Did you find a way to patch locally your changes before this is merged?

@BohdanPylypchuk
Copy link
Author

BohdanPylypchuk commented Sep 27, 2024

@joel-bitar Is it possible to merge this one as it's blocking all XCode 16 builds?

@BohdanPylypchuk Did you find a way to patch locally your changes before this is merged?

Yes. You can install the fork instead of the library npm install <ghusername>/<repoName> or use the patch-package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants