Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'is.chrome' #31 #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

onaralili
Copy link

No description provided.

Copy link
Owner

@joeltankam joeltankam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some fixes needed.
Add documentation in Readme.md, make sure all codacy tests pass

@@ -125,6 +125,13 @@ export function isWindowObject(value) {
return value != null && typeof value === 'object' && 'setInterval' in value;
}

/**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be done in this file, but environment.js as mentioned in the issue.
Check out @boristane pull request #40

@joeltankam
Copy link
Owner

Please apply the requested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants