Alt-click to recursive expand in html renderer #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carreau
reviewed
Aug 5, 2024
| @@ -19,6 +20,7 @@ export default class Frame { | |||
| group: Group | null; | |||
|
|
|||
| constructor(jsonObject: FrameData, parent: Frame|null = null, context: FrameContext = {groups:{}}) { | |||
| this.uuid = crypto.randomUUID() | |||
There was a problem hiding this comment.
this breaks for me. I get
Uncaught TypeError: crypto.randomUUID is not a function
at data:text/html
in the embeded script (chrome, latest). Even if crypto.randomUUID() from the console does return a UUID. Should crypto be somehow imported ?
There was a problem hiding this comment.
yeah, thats a bug, thanks for reporting. see #328
There was a problem hiding this comment.
Might just be some caching locally (ignore for now).
There was a problem hiding this comment.
No, i think you're right. This api only works in secure contexts. Some users will load pyinstrument from insecure contexts, like http servers. I guess data URIs are classed as insecure contexts too, maybe again the rules are a bit opaque. I've pushed a fix for that anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #320