Share some options between the CLI and magic.

[Carreau]

This refactor compute_render_options, to be shared between CLI and magic.

Add a few of the CLI options to be available in the magic.

The only thing I don't really like is that we redefine the help text options.

[Carreau]

See discussion in #334

[Carreau]

Closing and reopening to trigger CI.

[joerick]

sorry for the delay in the review. it looks good! just a couple comments

[Carreau]

sorry for the delay in the review. it looks good

No needs to apologize, this is open source and users are not owed anything.
I've learn myself to instead of apologizing, thanking contributor for their patience – at least I try. It's a subtle difference, but at least help me with framing my guilt and decrease burnout.

I will look back into this when possible,

Happy new year as well.

[joerick]

Happy new year! And thanks for your patience. Very wise words, I'll try to take them on ;)

I think a small simplification and this is ready to go. If it's not clear I'm happy to jump in and make the change, just let me know.

[Carreau]

And thanks for your patience

😄, thanks for yours.

Ah, the unicode/color support bit makes sense. Let's change the compute_render_options to use unicode_support and color_support (moving the file-related stuff to the call site) and then remove the _compute_render_options private version.

I'd rather do the idiomatic thing and raise exceptions on errors. I don't see a problem with magic.py importing OptionsParseError, it's already importing from main anyway. But if it is an issue, we could make it a ValueError and catch that instead.

It should be done, I now just let OptionsParseError bubble up, that seem to work if it's ok with you, so I don't even have to import it.

[joerick]

Great! Looks good.