Export renderers from pyinstrument.renderers
#356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type checkers don't like it when you use symbols that are not exported in that module. Putting the renderers in `__all__` will export them here so imports like this one pass mypy: from pyinstrument.renderers import HTMLRenderer Currently one must specify the specific module that owns the renderer to import it. from pyinstrument.renderers.html import HTMLRenderer
joerick
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type checkers don't like it when you use symbols that are not exported in that module. Putting the renderers in
__all__will export them here so imports like this one pass mypy:Currently one must specify the specific module that owns the renderer to import it.