Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a GitHub pages site with the bevy_ggrs example #331

Closed
wants to merge 7 commits into from

Conversation

johanhelsing
Copy link
Owner

Resolves #212

Code largely borrowed from bevy-shell-template

Supersedes: #244

@johanhelsing
Copy link
Owner Author

Trying to see if I can get the deploy job to pass...

This is rather unhelpful:
image

@johanhelsing johanhelsing temporarily deployed to github-pages September 21, 2023 08:31 — with GitHub Actions Inactive
@johanhelsing johanhelsing temporarily deployed to github-pages September 21, 2023 08:45 — with GitHub Actions Inactive
@johanhelsing johanhelsing temporarily deployed to github-pages September 21, 2023 08:46 — with GitHub Actions Inactive
@johanhelsing
Copy link
Owner Author

Okay, it's deploying now, but seems I glossed over the issue with the panic:

panicked at 'Cannot find element: #bevy_ggrs_example.', /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_winit-0.11.2/src/winit_windows.rs:137:21

@johanhelsing
Copy link
Owner Author

Should also check why the artifact is 85 mb, maybe we're not building release builds?

@johanhelsing
Copy link
Owner Author

Alternatively, we can do this with just wasm-opt/wasm-pack, and we can use the same launcher I use for all the embeds on my blog:

https://johanhelsing.studio/bevy-embed?app=extreme_4

Should allow the example to stay simple stupid (no trunk/yew or anything), and no hacks for canvas elements.

@simbleau
Copy link
Collaborator

Should also check why the artifact is 85 mb, maybe we're not building release builds?

That would definitely be the case. My builds are usually <10MB in release mode when I deploy my entire game (which includes matchbox).

@johanhelsing
Copy link
Owner Author

Closing in favor of #335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build and publish example projects in CI
3 participants