changed sorting to be case insensitive

johannesschobel · Apr 30, 2019 · e2f74aa · e2f74aa
1 parent 0ae2c1a
commit e2f74aa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -104,7 +104,7 @@ will return the next `20` entries that are located on `page 2`.
 
 
 ### `sort`
-In order to sort the results using different parameters, you can simply concatenate them using `,`. In order to provide `ASC` and `DESC` sorting, you may prepend a `-` before respective attribute.
+In order to sort the results using different parameters, you can simply concatenate them using `,`. In order to provide `ASC` and `DESC` sorting, you may prepend a `-` before respective attribute. Sorting is case-insensitive.
 
 For example
 ```php

diff --git a/src/JohannesSchobel/DingoQueryMapper/Operators/CollectionOperator.php b/src/JohannesSchobel/DingoQueryMapper/Operators/CollectionOperator.php
@@ -68,9 +68,9 @@ private function callbackSearchable($criteria)
             foreach ($criteria as $c) {
                 // normalize sort direction
                 $orderType = strtolower($c['direction']);
-                if ($first[$c['column']] < $second[$c['column']]) {
+                if (strtolower($first[$c['column']]) < strtolower($second[$c['column']])) {
                     return $orderType === "asc" ? -1 : 1;
-                } elseif ($first[$c['column']] > $second[$c['column']]) {
+                } elseif (strtolower($first[$c['column']]) > strtolower($second[$c['column']])) {
                     return $orderType === "asc" ? 1 : -1;
                 }
             }