handling zeros in kl-divergence from X

john-waczak · Jul 7, 2024 · 070d4d9 · 070d4d9
1 parent f92d504
commit 070d4d9
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/nmf-base.jl b/src/nmf-base.jl
@@ -190,10 +190,10 @@ function fit_kl!(nmf::NMFBase, X;
 
         # 3. Check convergence
         if i == 1
-            cost = kl_div(max.(nmf.W, eps(eltype(WH))), max.(nmf.H, eps(eltype(WH))), X)
+            cost = kl_div(max.(nmf.W, eps(eltype(WH))), max.(nmf.H, eps(eltype(WH))), max.(X, eps(eltype(X))))
         else
             cost_prev = cost
-            cost = kl_div(max.(nmf.W, eps(eltype(WH))), max.(nmf.H, eps(eltype(WH))), X)
+            cost = kl_div(max.(nmf.W, eps(eltype(WH))), max.(nmf.H, eps(eltype(WH))), max.(X, eps(eltype(X))))
             # cost = kl_div(nmf.W, nmf.H, X)
 
             diff= abs(cost - cost_prev)/min(abs(cost), abs(cost_prev))