-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix partial rendering bug #7
base: 1.3.2
Are you sure you want to change the base?
Conversation
Instead of rendering the partial its looking for a template
Am closing this to make a proper one that will fix the problem Why did someone mix Haml and Erb templates? |
Hi theCrab, with your tips I was able to solve a few things but now i get this error: <%= hook :admin_supplier_tabs , {:current => current} do %> <li<%== ' class="active"' if current == "Supplier Details" %>> <%= link_to "Supplier Details", edit_admin_supplier_url(@supplier) %> " at: .rvm/gems/ruby-1.9.3-p392/bundler/gems/spree_suppliers-4d92ce8ef90c/app/views/spree/admin/suppliers/_supplier_tabs.html.erb where line #3 raised: Did you get this error also? Any ideas on how to solve it? |
I will look through it and see what i can do. The owner of this repo is not meintaining it because he doesn't need it. I'll fix the bugs, then you can check my fork and use that. |
This gem was written for Spree 0.60 a few years ago and has been upgraded I will get to it when I have time, but cannot promise that it will be cheers On Wed, Mar 27, 2013 at 4:32 PM, The Crab [email protected] wrote:
|
I understand John, and thanks for all your effort, it's been appreciated! |
@lbramos, @radar has written about it and suggested a few solutions. The best one I have seen will require the Postgresql Database. Read it here and check out Ryan Bigg's Gists. I cant search for it but look into his gists and you'll find it. Read more on how to do it here and here and please if you find any more readings and resources, share them on this issue. Thanks theCrab |
Hi Thanks, Luis No dia 28/03/2013, às 12:33, The Crab [email protected] escreveu: Hi Ibramos, @radar has written about it and suggested a few solutions. The best one I Read more on how to do it here and here and please if you find any more Thanks theCrab On 28 Mar 2013, at 01:08, lbramos wrote:
— |
I still have to read everything more carefully but I think I should first post what I need to have... But should we continue this talk on this post or create something elsewhere for people to see and help us on this? |
When I found out spree_suppliers it seemed to solve all my troubles, or at least, most of them… It allowed multiple vendors, setting commissions for each sale, one single checkout (separating invoices and payments for each vendor), and a few more things… For the rest of the text I consider two different roles;
What it still doesn't accomplish and that I really need to, is:
The already existing functions should remain! I don't know if all these features should go to one or more expansions... And you guys, what do you want from "spree_suppliers"? |
Wow. Some of the additions are more UI facing than functional. I'll be happy to tinker with functional and leave the customization, ads and newsletter out. Its hard enough to get a spree shop going, and the others are already services that can be run on better apps like Mailchimp. Thanks for the list though. |
I know, I just wanted to put everything here... there were a couple of things missing, like vendor ranks, badges, and other stuff... but we should focus on main things! and from your side, what you would like to add? |
So, @theCrab do you want to join forces to attack this? Is there any other feature you would like to see? |
@lbramos yes. I'd like to work together on this. I'll look at what @johndavid400 has done then we can pick up from there. What is your Time Zone? I am GMT London. |
@theCrab me too (Portugal). |
@lbramos whats the best time to do this. I work daytime. So evening is best. |
For me it's also better to work at night, so I'll see you on IRC tonight for us to start! |
What's the status on this, lbramos and theCrab? What progress have you made? I've got most of the 1.3.2 code up and running after 7 commits. However, I'm not seeing the ability to associate a product with a supplier. Maybe that hasn't been ported yet. |
Hi @createthis . We stopped with some other projects... I'll be picking this up in about 2 weeks time... Maybe we can work together then! |
@createthis Me too. Just been too busy to start off. But I'll see how I can get something going again. I guess this project will act as an inspiration. |
I'm giving up on spree_suppliers. I got it functional enough to evaluate usefulness with 1.3.2, after hours of bug fixes. My purpose is the same as yours: multi-vendor functionality. spree-suppliers doesn't do that. It did give me enough information to roll my own, however. Good luck. |
Instead of rendering the partial its looking for a template