Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update esbuild → 0.19.1 (unknown) #21

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Aug 12, 2023


Welcome to Depfu 👋

This is one of the first three pull requests with dependency updates we've sent your way. We tried to start with a few easy patch-level updates. Hopefully your tests will pass and you can merge this pull request without too much risk. This should give you an idea how Depfu works in general.

After you merge your first pull request, we'll send you a few more. We'll never open more than seven PRs at the same time so you're not getting overwhelmed with updates.

Let us know if you have any questions. Thanks so much for giving Depfu a try!


Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ esbuild (^0.18.12 → ^0.19.1) · Repo · Changelog

Release Notes

0.19.1

  • Fix a regression with baseURL in tsconfig.json (#3307)

    The previous release moved tsconfig.json path resolution before --packages=external checks to allow the paths field in tsconfig.json to avoid a package being marked as external. However, that reordering accidentally broke the behavior of the baseURL field from tsconfig.json. This release moves these path resolution rules around again in an attempt to allow both of these cases to work.

  • Parse TypeScript type arguments for JavaScript decorators (#3308)

    When parsing JavaScript decorators in TypeScript (i.e. with experimentalDecorators disabled), esbuild previously didn't parse type arguments. Type arguments will now be parsed starting with this release. For example:

    @foo<number>
    @bar<number, string>()
    class Foo {}
  • Fix glob patterns matching extra stuff at the end (#3306)

    Previously glob patterns such as ./*.js would incorrectly behave like ./*.js* during path matching (also matching .js.map files, for example). This was never intentional behavior, and has now been fixed.

  • Change the permissions of esbuild's generated output files (#3285)

    This release changes the permissions of the output files that esbuild generates to align with the default behavior of node's fs.writeFileSync function. Since most tools written in JavaScript use fs.writeFileSync, this should make esbuild more consistent with how other JavaScript build tools behave.

    The full Unix-y details: Unix permissions use three-digit octal notation where the three digits mean "user, group, other" in that order. Within a digit, 4 means "read" and 2 means "write" and 1 means "execute". So 6 == 4 + 2 == read + write. Previously esbuild uses 0644 permissions (the leading 0 means octal notation) but the permissions for fs.writeFileSync defaults to 0666, so esbuild will now use 0666 permissions. This does not necessarily mean that the files esbuild generates will end up having 0666 permissions, however, as there is another Unix feature called "umask" where the operating system masks out some of these bits. If your umask is set to 0022 then the generated files will have 0644 permissions, and if your umask is set to 0002 then the generated files will have 0664 permissions.

  • Fix a subtle CSS ordering issue with @import and @layer

    With this release, esbuild may now introduce additional @layer rules when bundling CSS to better preserve the layer ordering of the input code. Here's an example of an edge case where this matters:

    /* entry.css */
    @import "a.css";
    @import "b.css";
    @import "a.css";
    /* a.css */
    @layer a {
      body {
        background: red;
      }
    }
    /* b.css */
    @layer b {
      body {
        background: green;
      }
    }

    This CSS should set the body background to green, which is what happens in the browser. Previously esbuild generated the following output which incorrectly sets the body background to red:

    /* b.css */
    @layer b {
      body {
        background: green;
      }
    }
    

    /* a.css */
    @layer a {
    body {
    background: red;
    }
    }

    This difference in behavior is because the browser evaluates a.css + b.css + a.css (in CSS, each @import is replaced with a copy of the imported file) while esbuild was only writing out b.css + a.css. The first copy of a.css wasn't being written out by esbuild for two reasons: 1) bundlers care about code size and try to avoid emitting duplicate CSS and 2) when there are multiple copies of a CSS file, normally only the last copy matters since the last declaration with equal specificity wins in CSS.

    However, @layer was recently added to CSS and for @layer the first copy matters because layers are ordered using their first location in source code order. This introduction of @layer means esbuild needs to change its bundling algorithm. An easy solution would be for esbuild to write out a.css twice, but that would be inefficient. So what I'm going to try to have esbuild do with this release is to write out an abbreviated form of the first copy of a CSS file that only includes the @layer information, and then still only write out the full CSS file once for the last copy. So esbuild's output for this edge case now looks like this:

    /* a.css */
    @layer a;
    

    /* b.css */
    @layer b {
    body {
    background: green;
    }
    }

    /* a.css */
    @layer a {
    body {
    background: red;
    }
    }

    The behavior of the bundled CSS now matches the behavior of the unbundled CSS. You may be wondering why esbuild doesn't just write out a.css first followed by b.css. That would work in this case but it doesn't work in general because for any rules outside of a @layer rule, the last copy shold still win instead of the first copy.

  • Fix a bug with esbuild's TypeScript type definitions (#3299)

    This release fixes a copy/paste error with the TypeScript type definitions for esbuild's JS API:

     export interface TsconfigRaw {
       compilerOptions?: {
    -    baseUrl?: boolean
    +    baseUrl?: string
         ...
       }
     }

    This fix was contributed by @privatenumber.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 12 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Aug 12, 2023
@depfu
Copy link
Contributor Author

depfu bot commented Aug 15, 2023

Closed in favor of #22.

@depfu depfu bot closed this Aug 15, 2023
@depfu depfu bot deleted the depfu/update/npm/esbuild-0.19.1 branch August 15, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants