Fix reading the regions back in v4 maps

johnnovak · Apr 7, 2024 · a2be6a2 · a2be6a2
1 parent 0597cd6
commit a2be6a2
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/src/persistence.nim b/src/persistence.nim
@@ -729,7 +729,7 @@ proc readCoordinateOptions(rr; parentChunk: string): CoordinateOptions =
 
 # }}}
 # {{{ readLevelRegions*()
-proc readLevelRegions(rr; regionCols: Natural,
+proc readLevelRegions(rr; levelCols: Natural,
                       version: Natural): tuple[regionOpts: RegionOptions,
                                                regions: Regions] =
   debug(fmt"Reading level regions...")
@@ -760,6 +760,8 @@ proc readLevelRegions(rr; regionCols: Natural,
 
   var regions: Regions = initRegions()
 
+  let regionCols = ceil(levelCols / regionOpts.colsPerRegion).int
+
   for regionIdx in 0..<numRegions:
     debug(fmt"regionIdx: {regionIdx}")
     pushDebugIndent()
@@ -776,6 +778,8 @@ proc readLevelRegions(rr; regionCols: Natural,
       RegionCoords(row: regionIdx div regionCols,
                    col: regionIdx mod regionCols)
 
+    debug(fmt"regionCoords: {regionCoords}")
+
     let name = rr.readWStr
     checkStringLength(name, "lvl.regn.region.name", RegionNameLimits)
 
@@ -862,8 +866,7 @@ proc readLevel(rr; levelId: Natural; version: Natural): Level =
   level.coordOpts = readCoordinateOptions(rr, groupChunkId.get)
 
   rr.cursor = regnCursor.get
-  (level.regionOpts, level.regions) = readLevelRegions(rr, level.regionCols,
-                                                       version)
+  (level.regionOpts, level.regions) = readLevelRegions(rr, level.cols, version)
 
   rr.cursor = cellCursor.get
 
@@ -1217,7 +1220,8 @@ proc writeLevelRegions(rw; l: Level) =
 
     rw.write(l.regions.numRegions.uint16)
 
-    # We need to write regions
+    # We write the regions row by row starting at the top-left corner
+    # at (0,0) region coords.
     for rc in l.regionCoords:
       let r = l.regions[rc].get
       rw.writeWStr(r.name)