Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking/Upgrade to Ember 4 #43

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ndekeister-us
Copy link

@ndekeister-us ndekeister-us commented Oct 31, 2022

⚠️ Breaking, drop support for older versions of Ember and Node <12 ; but allows compatibility for projects using Ember 4

Upgrade to Ember 4

  • run run ember-cli-update --to 4.4.0
    • fix some conflicts in README.md (some content has been automatically moved to CONTRIBUTING.md)
    • fix one conflict in tests/dummy/app/templates/application.hbs (text in h tag)
  • run npm install to update package-lock.json
  • run yarn lint:fix
  • fix lint erros

Also fix htmlSafe import, it is now available in @ember/template, importing it from @ember/string will result in this error on production build ->
Capture d’écran 2022-11-07 à 11 06 13

@ndekeister-us ndekeister-us marked this pull request as ready for review October 31, 2022 10:44
@ndekeister-us
Copy link
Author

ndekeister-us commented Oct 31, 2022

With current version app using Ember 4 have an error when rendering code using this addon

ReferenceError: Ember is not defined

(see https://github.com/johno/ember-linkify/blob/master/addon/helpers/linkify.js#L10)

It seems we have this error because we are using in this addon an old version (v6.6) of ember-cli-babel, see warning message from Ember when building the app consuming this addon

Usages of the Ember Global may be caused by an outdated ember-cli-babel dependency. The following steps may help:

* Upgrade the following addons to the latest version:
  * ember-linkify

### Important ###

In order to avoid repeatedly showing the same deprecation messages, no further deprecation messages will be shown for usages of the Ember Global until ember-cli-babel is upgraded to v7.26.6 or above.

To see all instances of this deprecation message, set the `EMBER_GLOBAL_DEPRECATIONS` environment variable to "all", e.g. `EMBER_GLOBAL_DEPRECATIONS=all ember test`.

cc @johno, if you could have a look / publish a release containing the update to Ember 4 🙏

@ndekeister-us ndekeister-us changed the title chore: upgrade to ember 4 Breaking/Upgrade to Ember 4 Oct 31, 2022
@adong
Copy link

adong commented Jan 23, 2023

@johno Is this still being maintained? Would love to see some ember 4 support. Thank you @ndekeister-us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants