Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert protected modificator for apiClient property and added getter … #122

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

artur-mietek
Copy link
Contributor

…for getSoapClient (5.x backward compatibility to access __getLastRequest and __getLastResponse for log purpose)

…for getSoapClient (5.x backward compatibility to access __getLastRequest and __getLastResponse for log purpose)
@artur-mietek artur-mietek mentioned this pull request Oct 9, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0f8fd91) 94.65% compared to head (2f05119) 98.22%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #122      +/-   ##
============================================
+ Coverage     94.65%   98.22%   +3.56%     
- Complexity      149      150       +1     
============================================
  Files            33       31       -2     
  Lines           468      451      -17     
============================================
  Hits            443      443              
+ Misses           25        8      -17     
Files Coverage Δ
src/GusApi/GusApi.php 100.00% <ø> (ø)
src/GusApi/Client/GusApiClient.php 94.87% <0.00%> (-5.13%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnzuk johnzuk merged commit 76b82ae into johnzuk:master Oct 9, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants