Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging to DD, attempt to make shutdown more graceful #12

Closed
wants to merge 30 commits into from
Closed

Add logging to DD, attempt to make shutdown more graceful #12

wants to merge 30 commits into from

Commits on Jan 17, 2024

  1. Add --include-deps option to Docker image pulls and retries to Docker… 

    … service startups
    @bjreath @rayalan
    bjreath authored and rayalan committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    d86f209 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #8 from joinhandshake/apr/4.16.0-port 

    Add --include-deps option to Docker image pulls and retries to Docker service startups
    @rayalan
    rayalan authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c5883ed View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Fix for graceful shutdown option. Don't call docker rm --force until … 

    …stop has returned
    David Kutalek authored and David Kutalek committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    0782f49 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Merge remote-tracking branch 'upstream/master' into davkutalek/premat… 

    …ure-kill-fix
    David Kutalek authored and David Kutalek committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    853a524 View commit details
    Browse the repository at this point in the history

  2. working on testing graceful shutdown fix

    David Kutalek authored and David Kutalek committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    af54780 View commit details
    Browse the repository at this point in the history

  3. fixed broken tests

    David Kutalek authored and David Kutalek committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    bebc54f View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. try running docker shell arg in [] to use exec mode

    David Kutalek authored and David Kutalek committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    1b6df23 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. try graceful compose shutdown

    David Kutalek authored and David Kutalek committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    dc72a0f View commit details
    Browse the repository at this point in the history

  2. pass service name arg to stop/wait

    David Kutalek authored and David Kutalek committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    553a8d6 View commit details
    Browse the repository at this point in the history

  3. exit upon getting term signal, otherwise service restarts

    David Kutalek authored and David Kutalek committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    4dbb936 View commit details
    Browse the repository at this point in the history

  4. Don't run docker command in subshell, obviously signals wont make it\!

    David Kutalek authored and David Kutalek committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    846e1bc View commit details
    Browse the repository at this point in the history

  5. rewrite run.sh to use docker compose exec form. All the tests broke, … 

    …not sure how to fix...
    David Kutalek authored and David Kutalek committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e5fd440 View commit details
    Browse the repository at this point in the history

  6. revert previous since it isn't working

    David Kutalek authored and David Kutalek committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    99c0fc3 View commit details
    Browse the repository at this point in the history

  7. attempt to run shell script without sh -c which creates new shell

    David Kutalek authored and David Kutalek committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    722c50e View commit details
    Browse the repository at this point in the history

  8. syntax fix

    David Kutalek authored and David Kutalek committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    47d200d View commit details
    Browse the repository at this point in the history

  9. try subshell with direct command

    David Kutalek authored and David Kutalek committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    aa1220c View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. refactor subshell to make it a little clearer, prevent exitcode -u issue

    David Kutalek authored and David Kutalek committed May 1, 2024
    Configuration menu
    Copy the full SHA
    8e06129 View commit details
    Browse the repository at this point in the history

  2. try not using a subshell again

    David Kutalek authored and David Kutalek committed May 1, 2024
    Configuration menu
    Copy the full SHA
    1a5d072 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Revert failed changes, Cleanup with some learnings. all tests passing

    David Kutalek authored and David Kutalek committed May 6, 2024
    Configuration menu
    Copy the full SHA
    385869d View commit details
    Browse the repository at this point in the history

  2. one last attempt with no subshell and no sh -c

    David Kutalek authored and David Kutalek committed May 6, 2024
    Configuration menu
    Copy the full SHA
    4eeae5d View commit details
    Browse the repository at this point in the history

  3. use subshell but not bin/sh

    David Kutalek authored and David Kutalek committed May 6, 2024
    Configuration menu
    Copy the full SHA
    2e15fd5 View commit details
    Browse the repository at this point in the history

  4. use bin/sh without e flag

    David Kutalek authored and David Kutalek committed May 6, 2024
    Configuration menu
    Copy the full SHA
    88a6602 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. fix service ref

    David Kutalek authored and David Kutalek committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8714720 View commit details
    Browse the repository at this point in the history

  2. revert prev

    David Kutalek authored and David Kutalek committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8189dcf View commit details
    Browse the repository at this point in the history

  3. no subshell

    David Kutalek authored and David Kutalek committed May 7, 2024
    Configuration menu
    Copy the full SHA
    d21572b View commit details
    Browse the repository at this point in the history

  4. no sh

    David Kutalek authored and David Kutalek committed May 7, 2024
    Configuration menu
    Copy the full SHA
    fccdf08 View commit details
    Browse the repository at this point in the history

  5. revert

    David Kutalek authored and David Kutalek committed May 7, 2024
    Configuration menu
    Copy the full SHA
    92ae4b4 View commit details
    Browse the repository at this point in the history

  6. add logging

    David Kutalek authored and David Kutalek committed May 7, 2024
    Configuration menu
    Copy the full SHA
    6490c0b View commit details
    Browse the repository at this point in the history

  7. revert remove sh

    David Kutalek authored and David Kutalek committed May 7, 2024
    Configuration menu
    Copy the full SHA
    2d801bb View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge tag 'v4.16.0.1' into davkutalek/premature-kill-fix

    David Kutalek authored and David Kutalek committed May 8, 2024
    Configuration menu
    Copy the full SHA
    130008f View commit details
    Browse the repository at this point in the history