Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): update bootstrap from v5.2.3 to v5.3.2 #645

Merged
merged 4 commits into from
Oct 18, 2023
Merged

build(deps): update bootstrap from v5.2.3 to v5.3.2 #645

merged 4 commits into from
Oct 18, 2023

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Aug 18, 2023 •
edited
Loading 

 @emotion/react   ^11.10.5  →  ^11.11.1
 bootstrap        ^5.2.3  →  ^5.3.2
 react-bootstrap  ^2.8.0  →  ^2.9.0

Hint: After you have pulled this PR, please execute npm install.

Still as draft as there are some todos:

@theborakompanioni theborakompanioni added dependencies Pull requests that update a dependency file UI/UX Issue related to cosmetics, design, or user experience labels Aug 18, 2023
@theborakompanioni theborakompanioni self-assigned this Aug 18, 2023
@theborakompanioni theborakompanioni marked this pull request as ready for review October 12, 2023 15:20
editwentyone
editwentyone approved these changes Oct 12, 2023
View reviewed changes
Copy link

@editwentyone editwentyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dark input fields are cool but we need more contrast (borders?) to actually distinguish them from the background, need to design and explore first on my side, but happy about any suggestions

@theborakompanioni theborakompanioni changed the title build(deps): update bootstrap from v5.2.3 to v5.3.1 build(deps): update bootstrap from v5.2.3 to v5.3.2 Oct 13, 2023
@theborakompanioni theborakompanioni merged commit 94be4c2 into master Oct 18, 2023
3 checks passed
@theborakompanioni theborakompanioni deleted the deps branch October 18, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@editwentyone editwentyone editwentyone approved these changes

Assignees

@theborakompanioni theborakompanioni

Labels
dependencies Pull requests that update a dependency file UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theborakompanioni @editwentyone