fix: show warning on missing fee config values #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theborakompanioni
force-pushed
the
chore/mandatory-config-values
branch
from
b42de4c to
1123af9
Compare
theborakompanioni
added a commit
that referenced
this pull request
Oct 12, 2023
* fix(send): show warning on missing fee config values * fix(fee): allow missing fee config values to be updated * feat(fee): open fee config modal from fee warning alert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #673.
Before this PR, the error message for missing
max_cj_fee_absandmax_cj_fee_relhas only been displayed after an attempt to send a collaborative transaction failed. The fee config modal was unusable if these configs had no value applied.After this PR, the message is shown immediately and the send form is disabled. The fee config modal can be used normally.
📸
How to test
Uncomment one (or both) of config values
max_cj_fee_absandmax_cj_fee_relin the filedefault.cfgand build your dev setup env withnpm run regtest:build.