ui(footer): improve label and colors of websocket indicator #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theborakompanioni
added
the
UI/UX
theborakompanioni
force-pushed
the
chore/websocket-connection-label
branch
from
1a86f40 to
e24b963
Compare
theborakompanioni
force-pushed
the
chore/websocket-connection-label
branch
from
e24b963 to
c93749b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the label on the websocket indicator just stated "connected" or "disconnected", which caused some confusion.
After this commit, it will be labelled "Websocket conntected" or "Websocket disconnected". Also, if the websocket is disconnected, the icon is coloured gray instead of red, as Jam will work normally without a stable websocket connection (UI responsiveness will be slower, but is functioning).
📸 Before
📸 After