dev: use npm run dev to run app in dev mode
#840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarnixCroes
approved these changes
Sep 11, 2024
package.json
Outdated
| @@ -47,8 +47,10 @@ | |||
| "react-router-dom": "^6.26.1" | |||
| }, | |||
| "scripts": { | |||
| "dev:start": "REACT_APP_JAM_DEV_MODE=true npm start", | |||
| "dev:start:secondary": "PORT=3001 JAM_BACKEND=jam-standalone JAM_API_PORT=29080 npm run dev:start", | |||
| "dev:start": "echo 'Deprecated command will be removed soon. Please use `npm run dev` instead.' && npm run dev", | |||
There was a problem hiding this comment.
Suggested change
| "dev:start": "echo 'Deprecated command will be removed soon. Please use `npm run dev` instead.' && npm run dev", | |
| "dev:start": "echo 'Deprecated command will be removed soon. Please use `npm run dev` instead.'", |
this could be removed maybe?
if you don't do install first and just run npm run dev then the && in front will not work ofc..
feel free to ignore
theborakompanioni
force-pushed
the
chore/dev-start
branch
from
cba9514 to
e4fd735
Compare
MarnixCroes
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvement for local development:
Changes the command for running in dev mode from
npm run dev:starttonpm run dev(e.g. as next.js does).