Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Comprehensive Tests for nl_BE Bank Provider #2142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AliYmn
Copy link

@AliYmn AliYmn commented Nov 27, 2024

What does this change

This change introduces comprehensive tests for the nl_BE bank provider in Faker. It covers the generation and validation of BBAN, IBAN, and SWIFT codes to ensure correctness and compliance with Belgian banking standards.

What was wrong

The existing implementation for the nl_BE bank provider lacked detailed testing for BBAN, IBAN, and SWIFT code generation. This made it harder to ensure the correctness of generated data, particularly for validation of check digits (e.g., mod-97 algorithm for BBAN and IBAN).

How this fixes it

  • Added detailed tests for:
    • BBAN format and check digit validation.
    • IBAN generation, including country code, format validation, and BBAN integration.
    • SWIFT code generation for both 8-character and 11-character formats, with validation for bank, country, and location/branch codes.
  • Ensures generated data matches expected Belgian banking standards.
  • Validates against external tools and libraries like is_valid_iban.

Fixes #2135

Checklist

  • I have read the documentation about CONTRIBUTING
  • I have read the documentation about Coding style
  • I have run make lint

@AliYmn AliYmn changed the title Fix: Add Comprehensive Tests for nl_BE Bank Provider (BBAN, IBAN, SWIFT) Fix Add Comprehensive Tests for nl_BE Bank Provider Nov 27, 2024
@AliYmn AliYmn changed the title Fix Add Comprehensive Tests for nl_BE Bank Provider Fix Comprehensive Tests for nl_BE Bank Provider Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Belgian IBAN is not valid
1 participant