WIP: Changes from filipvh #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add version For the compatibility with the future version of HASS * Compatibility with Home Assistant 2022.3.0 Import Coco Submodule in this module * Revert "Merge branch 'master' of https://github.com/filipvh/hass-nhc2 into filipvh-master" This reverts commit dc11149bddf99a6a9183023b218b074c114b923a, reversing changes made to d59f22dc1884da0ed9f2a7b6b8569dac87ce98d8. * Update fan.py Patch SPEED_HIGH, SPEED_LOW, SPEED_MEDIUM error in HASS 2022.4.0 Co-authored-by: cebos <[email protected]>
Change line 126 to make the update of the current temperature work (see issue joleys#34)
|
@tijsverkoyen : I believe most of these changes are already part of my repo. However, I used a slightly different approach compared to Filip. Do let me know if I missed something. |
|
@joleys you did not miss anything and I am the one who is completely wrong here. I was trying to resolve the feedback filipvh gave in filipvh/hass-nhc2#31. I just switched over to your integration and thought it would be beneficial to get the 2 repo's in line to combine the efforts. Really appreciate the swift feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from filipvh
Remark: this is untested. And I think there is some overlap for covers & shutters.
Should resolve: #27